Skip to content

Commit 1a70846

Browse files
authored
Remove leftover clean_logger call in tests (#11080)
1 parent e19d93f commit 1a70846

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

tests/plugins/test_tpu_spawn.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from torch.utils.data import DataLoader
2121

2222
from pytorch_lightning import Trainer
23-
from pytorch_lightning.loggers import LoggerCollection, TensorBoardLogger
2423
from pytorch_lightning.plugins.training_type import TPUSpawnPlugin
2524
from pytorch_lightning.utilities.exceptions import MisconfigurationException
2625
from tests.helpers.boring_model import BoringModel, RandomDataset
@@ -103,18 +102,3 @@ def test_model_tpu_one_core():
103102
model = BoringModelTPU()
104103
trainer.fit(model)
105104
assert "PT_XLA_DEBUG" not in os.environ
106-
107-
108-
@RunIf(tpu=True)
109-
@pytest.mark.parametrize("use_list", [False, True])
110-
def test_tensorboard_ddp_spawn_cleanup(use_list, tmpdir):
111-
tensorboard_logger = TensorBoardLogger(save_dir=tmpdir)
112-
assert tensorboard_logger._experiment is None
113-
tensorboard_logger.experiment # this property access will create the experiment
114-
assert tensorboard_logger._experiment is not None
115-
logger = [tensorboard_logger] if use_list else tensorboard_logger
116-
trainer = Trainer(strategy="ddp_spawn", accelerator="tpu", devices="auto", logger=logger)
117-
trainer.training_type_plugin._clean_logger(trainer)
118-
if use_list:
119-
assert isinstance(trainer.logger, LoggerCollection)
120-
assert tensorboard_logger._experiment is None

0 commit comments

Comments
 (0)