Skip to content

Remove leftover clean_logger call in tests #11080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 17, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 15, 2021

What does this PR do?

Follow up to #10896

The _clean_logger method was removed in #10896 and the test here was still using it, not failing of course because who would expect a test to fail due to AttributeError, right?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @justusschock @awaelchli @akihironitta @Borda

@mergify mergify bot added the ready PRs ready to be merged label Dec 15, 2021
make assertion fail
@awaelchli awaelchli enabled auto-merge (squash) December 16, 2021 23:51
@awaelchli awaelchli merged commit 1a70846 into master Dec 17, 2021
@awaelchli awaelchli deleted the tests/clean-logger branch December 17, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants