Skip to content

Commit 7879628

Browse files
authored
Fix access to logger attribute when multiple loggers are used (#14234)
* Fix access to logger attribute when multiple loggers are used * add changelog
1 parent bd55b56 commit 7879628

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

src/pytorch_lightning/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
7070
- Fixed an assertion error when using a `ReduceOnPlateau` scheduler with the Horovod strategy ([#14215](https://github.com/Lightning-AI/lightning/pull/14215))
7171

7272

73+
- Fixed an `AttributeError` when accessing `LightningModule.logger` and the Trainer has multiple loggers ([#14234](https://github.com/Lightning-AI/lightning/pull/14234))
74+
7375

7476
## [1.7.2] - 2022-08-17
7577

src/pytorch_lightning/core/module.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import numbers
1919
import os
2020
import tempfile
21+
import warnings
2122
import weakref
2223
from contextlib import contextmanager
2324
from pathlib import Path
@@ -38,7 +39,7 @@
3839
from pytorch_lightning.core.saving import ModelIO
3940
from pytorch_lightning.loggers import Logger, LoggerCollection
4041
from pytorch_lightning.trainer.connectors.logger_connector.fx_validator import _FxValidator
41-
from pytorch_lightning.utilities import _IS_WINDOWS, _TORCH_GREATER_EQUAL_1_10, GradClipAlgorithmType, warnings
42+
from pytorch_lightning.utilities import _IS_WINDOWS, _TORCH_GREATER_EQUAL_1_10, GradClipAlgorithmType
4243
from pytorch_lightning.utilities.apply_func import apply_to_collection, convert_to_tensors
4344
from pytorch_lightning.utilities.cloud_io import get_filesystem
4445
from pytorch_lightning.utilities.distributed import distributed_available, sync_ddp

tests/tests_pytorch/deprecated_api/test_remove_1-8.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -692,6 +692,12 @@ def test_v1_8_0_logger_collection(tmpdir):
692692
with pytest.deprecated_call(match="`LoggerCollection` is deprecated in v1.6"):
693693
_ = LoggerCollection([logger1, logger2])
694694

695+
model = BoringModel()
696+
trainer = Trainer(logger=[logger1, logger2])
697+
model.trainer = trainer
698+
with pytest.deprecated_call(match="logger` will return the first logger"):
699+
_ = model.logger
700+
695701

696702
def test_v1_8_0_precision_plugin_checkpoint_hooks(tmpdir):
697703
class PrecisionPluginSaveHook(PrecisionPlugin):

0 commit comments

Comments
 (0)