-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix access to logger attribute when multiple loggers are used #14234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1882817
to
1f681b3
Compare
rohitgr7
approved these changes
Aug 17, 2022
carmocca
approved these changes
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #14234 +/- ##
=========================================
- Coverage 85% 76% -9%
=========================================
Files 330 330
Lines 26760 26761 +1
=========================================
- Hits 22797 20348 -2449
- Misses 3963 6413 +2450 |
awaelchli
added a commit
that referenced
this pull request
Aug 18, 2022
* Fix access to logger attribute when multiple loggers are used
nicolai86
pushed a commit
that referenced
this pull request
Aug 23, 2022
* Fix access to logger attribute when multiple loggers are used * add changelog
lexierule
pushed a commit
that referenced
this pull request
Aug 25, 2022
* Fix access to logger attribute when multiple loggers are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
lightningmodule
pl.LightningModule
logger
Related to the Loggers
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14231
To be included in 1.7.x. The code we fix here will also be removed later on as part of the deprecation ending in 1.8.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @awaelchli @edward-io @Borda @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @carmocca @justusschock @ninginthecloud @jjenniferdai