Skip to content

3 Docker CI jobs failing on master #9676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniellepintz opened this issue Sep 24, 2021 · 9 comments · Fixed by #9679
Closed

3 Docker CI jobs failing on master #9676

daniellepintz opened this issue Sep 24, 2021 · 9 comments · Fixed by #9679
Labels
bug Something isn't working ci Continuous Integration won't fix This will not be worked on

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Sep 24, 2021

🐛 Bug

These are the failing jobs:

To Reproduce

check latest CI jobs on master

Expected behavior

Green CI!

@daniellepintz daniellepintz added the bug Something isn't working label Sep 24, 2021
@daniellepintz
Copy link
Contributor Author

daniellepintz commented Sep 24, 2021

For build-XLA (3.7, nightly) it seems to be failing because the nightly version of Pytorch was updated to 1.11, and we don't have torch 1.11 in
https://github.com/PyTorchLightning/pytorch-lightning/blob/41e3be197f5a2fd0f65b37b743ebfd157a55595d/requirements/adjust_versions.py#L7-L17

The two options I see to solve this are we can update this list in adjust_versions, or we can remove the "nightly" version, similarly to what we are doing in #9673.

@daniellepintz
Copy link
Contributor Author

daniellepintz commented Sep 24, 2021

For the build-CUDA Timeout errors, we are seeing this logged a lot before the Timeout INFO: pip is looking at multiple versions of jsonargparse[signatures] to determine which version is compatible with other requirements. This could take a while.

cc @Borda

@daniellepintz
Copy link
Contributor Author

We may have to pin the dependencies to a specific version number as per https://stackoverflow.com/questions/65122957/resolving-new-pip-backtracking-runtime-issue

Still doesn't explain why we didn't have this problem before :/

@Borda
Copy link
Member

Borda commented Sep 24, 2021

The download timeouts are most likely temporary connection issues... Or how frequently is it happening over all PRs?

@daniellepintz
Copy link
Contributor Author

It is happening pretty frequently in the past few PRs, but it doesn't seem completely deterministic. Maybe it is just temporary connection issues

@Borda
Copy link
Member

Borda commented Sep 24, 2021

The looking for a version is becase pip become more strict on dependency intersection, so it is possible that argparaet ban some other package versions which are required by another packages...
You can try to comment some packages to find which two are not feasible (another sanity check is that this shall happen only for latest configuration not for minimal, right?

On the requirements side, conda and pip list is installed separately so there shall not be any conflicts, in fact the conda may be overwritten by pip as it runs after it

@awaelchli awaelchli added the ci Continuous Integration label Sep 24, 2021
@daniellepintz
Copy link
Contributor Author

This is interesting, most recent commits on master have 7-8 failing jobs with this Timeout, but a few of them are just fine, such as this one: https://github.com/PyTorchLightning/pytorch-lightning/runs/3702218949
This successful job still has some errors in the logs though, which are different than those in the Timeout:
https://gist.github.com/daniellepintz/4c5c2aa0827a1e39fcfe94a3dd5d3e39

@stale
Copy link

stale bot commented Oct 25, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Oct 25, 2021
@carmocca
Copy link
Contributor

carmocca commented Oct 26, 2021

I believe all have been fixed with #10087 and #10088 (see PR checks on the latter)

To be more concrete, the consistent failures have been fixed but the jobs are still flaky due to caches/timeouts/connectivity. But this is already being discussed in #10060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration won't fix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants