Skip to content

docker Conda timeout #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

docker Conda timeout #10087

merged 2 commits into from
Oct 25, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 22, 2021 •
edited
Loading

What does this PR do?

Fix building docker for Conda

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Oct 22, 2021
@Borda Borda marked this pull request as ready for review October 22, 2021 19:47
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

4 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Oct 22, 2021
@Borda Borda enabled auto-merge (squash) October 22, 2021 19:57
@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #10087 (e8eb0f4) into master (c9bc10c) will decrease coverage by 0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #10087     +/-   ##
=========================================
- Coverage      92%      92%     -0%     
=========================================
  Files         182      182             
  Lines       16111    17721   +1610     
=========================================
+ Hits        14894    16312   +1418     
- Misses       1217     1409    +192

@Borda Borda merged commit 0e0247a into master Oct 25, 2021
@Borda Borda deleted the cd/build-conda branch October 25, 2021 20:56
@carmocca carmocca mentioned this pull request Oct 26, 2021
Closed
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
@Borda @ninginthecloud
docker Conda timeout (Lightning-AI#10087)
3c834f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@akihironitta akihironitta akihironitta approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@s-rog s-rog s-rog approved these changes

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Borda @carmocca @tchaton @justusschock @akihironitta @kaushikb11 @s-rog