Skip to content

Don't run .github/*.py when running pytest #10012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Don't run .github/*.py when running pytest #10012

merged 1 commit into from
Oct 19, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Oct 19, 2021 •
edited
Loading

What does this PR do?

Fixes the discussion #9181.

Problem

As reported in the linked discussion, it seems vscode runs the following to collect test items:

~/conda/envs/dev39/bin/python ~/.vscode-server/extensions/ms-python.python-2021.10.1317843341/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir ~/work/pytorch-lightning -s --cache-clear

which runs .github/*.py, and pytorch_lightning/__about__.py gets modified intentionally.

TODO

  • Exclude .github/ in the pytest config

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the ci Continuous Integration label Oct 19, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@akihironitta akihironitta changed the title Don't run .github/*.py with pytest --rootdir Don't run .github/*.py when running pytest Oct 19, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

7 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@akihironitta akihironitta mentioned this pull request Oct 19, 2021
Closed
@kaushikb11 kaushikb11 added this to the v1.5 milestone Oct 19, 2021
@Borda Borda merged commit 8f14e77 into master Oct 19, 2021
@Borda Borda deleted the tests/dont-run-.github branch October 19, 2021 07:57
@akihironitta akihironitta mentioned this pull request Oct 22, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@carmocca carmocca Awaiting requested review from carmocca

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@akihironitta @Borda @justusschock @kaushikb11