Skip to content

Mark trainer.accelerator_connector as protected #10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

daniellepintz
Copy link
Contributor

What does this PR do?

Part of #9778

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10032 (cca90a0) into master (76081fb) will decrease coverage by 4%.
The diff coverage is 75%.

❗ Current head cca90a0 differs from pull request most recent head e95b17e. Consider uploading reports for the commit e95b17e to get more accurate results

@@           Coverage Diff            @@
##           master   #10032    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         182      182            
  Lines       16157    16111    -46     
========================================
- Hits        14947    14273   -674     
- Misses       1210     1838   +628     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot removed the has conflicts label Oct 21, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2021
@tchaton tchaton enabled auto-merge (squash) October 25, 2021 11:30
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@daniellepintz daniellepintz enabled auto-merge (squash) October 25, 2021 18:50
@daniellepintz daniellepintz merged commit 1f7bd66 into Lightning-AI:master Oct 25, 2021
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants