-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove the DeepSource integration #10056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Codecov Report
@@ Coverage Diff @@
## master #10056 +/- ##
=======================================
Coverage 93% 93%
=======================================
Files 180 180
Lines 15908 15908
=======================================
Hits 14722 14722
Misses 1186 1186 |
Just disable it in UI/Github settings, removing config does not do anything, moreover, I would keep it :] |
Yeah, I'll do that once it's approved
There's no need. We have it in the git history if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense, thanks! This check is pretty noisy and is often the reason for red CI.
DeepSource is now failing on PRs with "failure to create analysis" - can we disable it in the settings? |
Waiting for somebody with access to the deepsource account to do it. |
This reverts commit 84706a2.
What does this PR do?
Part of #9445
2 main reasons why this did not catch on:
Ideally, we would remove the CI check but keep some bot that comments on the PR with the list of problems. I don't think that is possible. (feature suggestion for @deepsourcelabs)
This only removes the configuration file. A person with admin resources will still need to disable the integration.
cc @Borda @daniellepintz
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review