Skip to content

Remove the DeepSource integration #10056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Remove the DeepSource integration #10056

merged 1 commit into from
Oct 21, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 20, 2021

What does this PR do?

Part of #9445

2 main reasons why this did not catch on:

  • Too many false positives
  • Accessing the report takes too many clicks

Ideally, we would remove the CI check but keep some bot that comments on the PR with the list of problems. I don't think that is possible. (feature suggestion for @deepsourcelabs)

This only removes the configuration file. A person with admin resources will still need to disable the integration.

cc @Borda @daniellepintz

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Oct 20, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 20, 2021
@carmocca carmocca self-assigned this Oct 20, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10056 (ded87d3) into master (5b30a65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10056   +/-   ##
=======================================
  Coverage      93%      93%           
=======================================
  Files         180      180           
  Lines       15908    15908           
=======================================
  Hits        14722    14722           
  Misses       1186     1186           

@Borda
Copy link
Member

Borda commented Oct 20, 2021

Just disable it in UI/Github settings, removing config does not do anything, moreover, I would keep it :]

@carmocca
Copy link
Contributor Author

carmocca commented Oct 20, 2021

Just disable it in UI/Github settings, removing config does not do anything, moreover

Yeah, I'll do that once it's approved

I would keep it

There's no need. We have it in the git history if necessary

Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, thanks! This check is pretty noisy and is often the reason for red CI.

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@carmocca carmocca added the admin Requires admin privileges to merge label Oct 20, 2021
@kaushikb11 kaushikb11 merged commit 84706a2 into master Oct 21, 2021
@kaushikb11 kaushikb11 deleted the ci/bye-deepsource branch October 21, 2021 08:25
@daniellepintz
Copy link
Contributor

DeepSource is now failing on PRs with "failure to create analysis" - can we disable it in the settings?

@carmocca
Copy link
Contributor Author

Waiting for somebody with access to the deepsource account to do it.

awaelchli added a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Requires admin privileges to merge ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants