Skip to content

Fix optimizers overloads typing annotation #10069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2021
Merged

Fix optimizers overloads typing annotation #10069

merged 4 commits into from
Oct 25, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes #9990 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working docs Documentation related labels Oct 21, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 21, 2021
@carmocca carmocca self-assigned this Oct 21, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2021
@mergify mergify bot requested a review from a team October 21, 2021 15:48
@carmocca carmocca enabled auto-merge (squash) October 22, 2021 02:17
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10069 (dc9d8d1) into master (7eb2edf) will decrease coverage by 3%.
The diff coverage is 67%.

❗ Current head dc9d8d1 differs from pull request most recent head 3f64866. Consider uploading reports for the commit 3f64866 to get more accurate results

@@           Coverage Diff            @@
##           master   #10069    +/-   ##
========================================
- Coverage      91%      89%    -3%     
========================================
  Files         182      182            
  Lines       16054    16114    +60     
========================================
- Hits        14625    14275   -350     
- Misses       1429     1839   +410     

@carmocca carmocca merged commit 43c70ec into master Oct 25, 2021
@carmocca carmocca deleted the typing/bugfix-opt branch October 25, 2021 16:51
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants