Skip to content

Raise exception for strategy=ddp_cpu|tpu_spawn #10185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 27, 2021

What does this PR do?

Part of #9932

No usage yet:

$ grep -iIrn 'stategy="ddp_cpu' pytorch_lightning docs tests
$ grep -iIrn 'stategy="tpu_spawn' pytorch_lightning docs tests

Does your PR introduce any breaking changes? If yes, please list them.

None, strategy is unreleased.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Oct 27, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 27, 2021
@carmocca carmocca self-assigned this Oct 27, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca added the priority: 0 High priority task label Oct 27, 2021
@carmocca carmocca mentioned this pull request Oct 27, 2021
12 tasks
@mergify mergify bot added the ready PRs ready to be merged label Oct 28, 2021
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaushikb11 kaushikb11 enabled auto-merge (squash) October 28, 2021 14:40
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@kaushikb11 kaushikb11 merged commit e4eb61d into master Oct 29, 2021
@kaushikb11 kaushikb11 deleted the feat/exception-strategy branch October 29, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants