-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Minimize the number of docker jobs #10202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10202 +/- ##
=======================================
Coverage 89% 89%
=======================================
Files 180 180
Lines 16184 16146 -38
=======================================
- Hits 14324 14317 -7
+ Misses 1860 1829 -31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
how not testing shall help? if I read it correctly we just say we do not test some confirmation so if they do not work we do not care? |
This is already the case. Since these jobs are not required, they often fail and nobody cares (until there is a problem and CI gets blocked). This PR cuts the unused images, so we only keep those that are used for actual testing jobs later. |
Co-authored-by: Jirka Borovec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
What does this PR do?
We currently generate more Docker images than we use for testing. This PR changes that to reduce the number of possible failures.
This reduces it from 49 docker jobs to 16
Part of #10060
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review