Skip to content

Fix iterating over a DummyLogger when fast_dev_run > 0 #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 29, 2021

What does this PR do?

Fixes #10201

The user had multiple loggers, i.e., Trainer(logger=[logger1, logger2]).
The user did this in training_step:

for logger in self.logger
    logger.xyz()

However, when Trainer(fast_dev_run=True, logger=[logger1, logger2]), self.logger is replaced with a DummyLogger and iterating over self.logger would result in infinite iteration.

The proposed fix makes the DummyLogger an empty iterable.
Test fails without the fix.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli changed the title add fix and test Fix iterating over a DummyLogger Oct 29, 2021
@awaelchli awaelchli changed the title Fix iterating over a DummyLogger Fix iterating over a DummyLogger when fast_dev_run > 0 Oct 29, 2021
@awaelchli awaelchli added the bug Something isn't working label Oct 29, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 29, 2021
@awaelchli awaelchli added the logger Related to the Loggers label Oct 29, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 29, 2021 07:07
@rohitgr7 rohitgr7 merged commit 3f9dfe4 into master Oct 29, 2021
@rohitgr7 rohitgr7 deleted the bugfix/dummy-iterable branch October 29, 2021 07:23
@awaelchli awaelchli mentioned this pull request Aug 18, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer runs indefinitely if fast_dev_run=True when iterating over self.logger
4 participants