Skip to content

reset train dataloader after OOM #10243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

veronicamorfi
Copy link

@veronicamorfi veronicamorfi commented Oct 29, 2021

What does this PR do?

Fixes #9625
binsearch scaling in batch size scaling wasn't reseting the dataloader batchsize after an OOM error.
Calling the reset function for the train dataloader fixes that.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton tchaton added this to the v1.6.x milestone Nov 1, 2021
@awaelchli awaelchli modified the milestones: v1.6.x, 1.5.x Nov 3, 2021
@mogwai
Copy link

mogwai commented Feb 15, 2022

Is this coming in to the next release?

@Borda Borda modified the milestones: 1.5.x, 1.6 Mar 21, 2022
@carmocca carmocca added the tuner label Mar 28, 2022
@carmocca carmocca removed this from the 1.6 milestone Mar 28, 2022
@carmocca
Copy link
Contributor

@mogwai This PR still needs to address the comments and write a test etc.

You can work on a new PR to finish it if you are interested in contributing!

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 24, 2022

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tuner won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch_size selected by auto_scale_batch_size triggers out of memory error
7 participants