-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Drop torch 1.6 testing #10390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Drop torch 1.6 testing #10390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aki Nitta <[email protected]>
This reverts commit 3a6acad.
12 tasks
carmocca
commented
Nov 8, 2021
carmocca
commented
Nov 8, 2021
tchaton
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
justusschock
approved these changes
Nov 9, 2021
ethanwharris
approved these changes
Nov 10, 2021
akihironitta
approved these changes
Nov 11, 2021
Co-authored-by: Aki Nitta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10390 +/- ##
=======================================
Coverage 92% 93%
=======================================
Files 179 178 -1
Lines 16292 16220 -72
=======================================
- Hits 15063 15013 -50
+ Misses 1229 1207 -22 |
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
* Drop torch 1.6 support * Drop 1.6 support * Update CHANGELOG * Fixes * Split change * Undo change * 1.7 -> 1.7.1 pytorch/pytorch#47354 * Force trigger nightly * Update .github/workflows/events-nightly.yml Co-authored-by: Aki Nitta <[email protected]> * Revert 1.7.1 change - try wildcard * Update adjust versions and test it * Undo test changes * Revert "Undo test changes" This reverts commit 3a6acad. * Update CHANGELOG.md Co-authored-by: Aki Nitta <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #10367
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review