-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Change attributes of RichProgressBarTheme
dataclass
#10454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change attributes of RichProgressBarTheme
dataclass
#10454
Conversation
|
Ah, makes sense! |
RichProgressBarTheme
dataclass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaushikb11 with the thorough review :)
This is awesome @Raahul-Singh and I really like the theme you have! We had to go for a more monotone theme primarily out of user cases (something standard rather than bright and colourful).
I personally would be up for themes, but this is just because I like pretty visuals :P
Co-authored-by: Kaushik B <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Haha, @SeanNaren you and me both. I am planning on making a full cyberpunk-esque theme for my projects. Gotta thank the Lightning team for introducing me to |
Thank you @kaushikb11 for all the help and feedback :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Codecov Report
@@ Coverage Diff @@
## master #10454 +/- ##
========================================
- Coverage 92% 89% -4%
========================================
Files 179 179
Lines 16293 16294 +1
========================================
- Hits 15064 14438 -626
- Misses 1229 1856 +627 |
Co-authored-by: Kaushik B <[email protected]>
Co-authored-by: Kaushik B <[email protected]>
…0454) Co-authored-by: Kaushik B <[email protected]>
Just some name changes to Rich Progress Bar Themes.
Closes #10435
To visually test the params, I created the following theme:
This is what I get:
Considering this, I propose we change the params to the following:
progress_bar_complete
->progress_bar_completed_so_far
progress_bar_finished
->progress_bar_on_completion
batch_process
->batch_progress
Also, I am a little confused about what
progress_bar_pulse
does. Could you guys help me out with this?