-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Move benchmarks into the test directory #10614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
pls, share the motivations? I do not see it in the other PR #7614 neither 🐰 |
@Borda the other PR has "fixes" and "closes" linking to issues/PRs that show the motivation.
I don't get what you are saying, but the reason it needs to be moved is that the benchmarks depend on many testing components (see the imports in the code), which means that since we will not be distributing them together after #7614, the imports will not work. This is the same reason why the Additionally, these benchmarks are tests in the sense that they are run in our CI and their failure acts as a test failure. |
What does this PR do?
Part of #7614
Requested by @Borda in #7614 (review)
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @carmocca @akihironitta @Borda