Skip to content

Move benchmarks into the test directory #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 18, 2021

What does this PR do?

Part of #7614

Requested by @Borda in #7614 (review)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Nov 18, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 18, 2021
@carmocca carmocca self-assigned this Nov 18, 2021
@carmocca carmocca enabled auto-merge (squash) November 18, 2021 17:42
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@Borda
Copy link
Member

Borda commented Nov 18, 2021

pls, share the motivations? I do not see it in the other PR #7614 neither 🐰
also not sure why shall move benchmarks to tests, while benchmarks work as parity testing and then shall be excluded from normal testing...

@carmocca
Copy link
Contributor Author

carmocca commented Nov 18, 2021

pls, share the motivations? I do not see it in the other PR #7614 neither

@Borda the other PR has "fixes" and "closes" linking to issues/PRs that show the motivation.

also not sure why shall move benchmarks to tests, while benchmarks work as parity testing and then shall be excluded from normal testing...

I don't get what you are saying, but the reason it needs to be moved is that the benchmarks depend on many testing components (see the imports in the code), which means that since we will not be distributing them together after #7614, the imports will not work. This is the same reason why the MNIST implementation was copied in #7614, but in this case, moving the directories together instead.

Additionally, these benchmarks are tests in the sense that they are run in our CI and their failure acts as a test failure.

@mergify mergify bot added the ready PRs ready to be merged label Nov 19, 2021
@carmocca carmocca disabled auto-merge November 19, 2021 01:38
@carmocca carmocca merged commit 5788789 into master Nov 19, 2021
@carmocca carmocca deleted the ci/move-benchmarks-into-tests branch November 19, 2021 02:07
@carmocca carmocca modified the milestones: 1.5.x, 1.6 Nov 22, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@carmocca carmocca modified the milestones: 1.6, 1.5.x Nov 24, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants