Skip to content

Remove redundant fit call from accelerator connector test #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 19, 2021

What does this PR do?

Removes a redundant fit call from a test that does not need it for its assertions.
We have seen this test stall on a few PRs in the CI (not reproducible locally).
With a bit of luck, the removal of this fit call will (temporarily) unblock us.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda

@awaelchli awaelchli changed the title remove redundant fit call from accelerator connector test Remove redundant fit call from accelerator connector test Nov 19, 2021
@awaelchli awaelchli marked this pull request as ready for review November 19, 2021 00:48
@awaelchli awaelchli added this to the 1.6 milestone Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #10626 (28ccce0) into master (700521c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10626   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         178      178           
  Lines       16266    16266           
=======================================
  Hits        14923    14923           
  Misses       1343     1343           

@mergify mergify bot added the ready PRs ready to be merged label Nov 19, 2021
@kaushikb11 kaushikb11 merged commit c09c9c7 into master Nov 19, 2021
@kaushikb11 kaushikb11 deleted the tests/redundant-fit-call branch November 19, 2021 06:49
@rohitgr7 rohitgr7 mentioned this pull request Nov 20, 2021
11 tasks
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants