Skip to content

Do not sanity check on reload #10785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 27, 2021

What does this PR do?

When we restart from a checkpoint, we don't want to run the validation sanity check as it can override the current state of the validation loop, which should have been restored if fault-tolerance is enabled.

Part of #8578

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud @ananthsub

@carmocca carmocca added fault tolerance loops Related to the Loop API labels Nov 27, 2021
@carmocca carmocca added this to the 1.6 milestone Nov 27, 2021
@carmocca carmocca self-assigned this Nov 27, 2021
@carmocca carmocca marked this pull request as ready for review November 27, 2021 04:22
@mergify mergify bot added the ready PRs ready to be merged label Nov 29, 2021
@carmocca carmocca enabled auto-merge (squash) November 29, 2021 15:03
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Mind adding a test?

@carmocca carmocca merged commit 088818f into master Nov 29, 2021
@carmocca carmocca deleted the bugfix/do-not-sanity-check-on-reload branch November 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault tolerance loops Related to the Loop API ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants