Skip to content

Trigger TPU CI only on branches with a pull request #10932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 3, 2021

What does this PR do?

The current CI for TPU runs on branches created without a pull request. This is a waste of resources. The same rules we have for other workflows should apply to TPU CI.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @carmocca @akihironitta @Borda @kaushikb11

@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit ci Continuous Integration labels Dec 3, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Dec 3, 2021
@awaelchli awaelchli marked this pull request as ready for review December 4, 2021 20:31
@mergify mergify bot added the ready PRs ready to be merged label Dec 4, 2021
@mergify mergify bot requested a review from a team December 4, 2021 21:52
@awaelchli awaelchli enabled auto-merge (squash) December 5, 2021 06:31
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #10932 (5e2b564) into master (a28b4cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10932   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16553    16553           
=======================================
  Hits        15204    15204           
  Misses       1349     1349           

@awaelchli awaelchli merged commit 3d59a2f into master Dec 5, 2021
@awaelchli awaelchli deleted the ci/trigger-tpu branch December 5, 2021 06:55
awaelchli added a commit that referenced this pull request Dec 7, 2021
lexierule pushed a commit that referenced this pull request Dec 7, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants