-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Return only unique names/versions for LoggerCollection #10976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return only unique names/versions for LoggerCollection #10976
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10976 +/- ##
=======================================
Coverage 88% 88%
=======================================
Files 177 177
Lines 16576 16536 -40
=======================================
- Hits 14588 14556 -32
+ Misses 1988 1980 -8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, this is a breaking change. I labelled it with milestone 1.6 for now. I would be careful to include this in the 1.5.x release since this impacts the path where artifacts are stored, so it may also impact resuming for some users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!!! happy holidays
Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
Fixes #10954
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃