Skip to content

Return only unique names/versions for LoggerCollection #10976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 23, 2021
Merged

Return only unique names/versions for LoggerCollection #10976

merged 10 commits into from
Dec 23, 2021

Conversation

twsl
Copy link
Contributor

@twsl twsl commented Dec 7, 2021

What does this PR do?

Fixes #10954

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@twsl twsl marked this pull request as ready for review December 7, 2021 15:51
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) December 9, 2021 13:20
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #10976 (6d064f9) into master (9da78a9) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 6d064f9 differs from pull request most recent head 7947e75. Consider uploading reports for the commit 7947e75 to get more accurate results

@@           Coverage Diff           @@
##           master   #10976   +/-   ##
=======================================
  Coverage      88%      88%           
=======================================
  Files         177      177           
  Lines       16576    16536   -40     
=======================================
- Hits        14588    14556   -32     
+ Misses       1988     1980    -8     

@mergify mergify bot added the has conflicts label Dec 9, 2021
@awaelchli awaelchli added the breaking change Includes a breaking change label Dec 14, 2021
@awaelchli awaelchli modified the milestones: 1.6, 1.5.x Dec 14, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, this is a breaking change. I labelled it with milestone 1.6 for now. I would be careful to include this in the 1.5.x release since this impacts the path where artifacts are stored, so it may also impact resuming for some users.

@mergify mergify bot removed the has conflicts label Dec 21, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!!! happy holidays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoggerCollection name redundancy
5 participants