-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Deprecate call_hook
#10979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate call_hook
#10979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this back.
Codecov Report
@@ Coverage Diff @@
## master #10979 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 177 177
Lines 16520 16545 +25
========================================
- Hits 15164 14556 -608
- Misses 1356 1989 +633 |
What does this PR do?
Follow up to #10575. I accidentally removed
call_hook
in that PR but I meant to deprecate it.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃