Skip to content

Mark Trainer.run_stage as protected #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 121 commits into from
Dec 17, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 9, 2021

What does this PR do?

Follow up to #10896
Part of #10987
Parto of #7740

Trainer.run_stage was previously public and accessed in the dispatch methods of the TTP. After #10896 it remains a Trainer exclusive method.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @tchaton

@awaelchli awaelchli added the deprecation Includes a deprecation label Dec 9, 2021
Base automatically changed from refactor/spawn/dispatch to master December 9, 2021 18:56
@awaelchli awaelchli added this to the 1.6 milestone Dec 15, 2021
@awaelchli awaelchli marked this pull request as ready for review December 15, 2021 04:52
@awaelchli awaelchli requested a review from ananthsub December 15, 2021 04:53
@mergify mergify bot added the ready PRs ready to be merged label Dec 15, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 15, 2021 11:57
@mergify mergify bot removed the has conflicts label Dec 17, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli merged commit 210ff84 into master Dec 17, 2021
@awaelchli awaelchli deleted the refactor/protected-run-stage branch December 17, 2021 12:46
@Borda Borda mentioned this pull request Mar 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants