Skip to content

Update the TQDM progress bar on_train_epoch_end #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 15, 2021

What does this PR do?

Fixes #10653

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @awaelchli

@carmocca carmocca enabled auto-merge (squash) December 15, 2021 04:08
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @awaelchli I'm struggling to understand why this fixes it. Could you maybe add a comment on that?

@awaelchli
Copy link
Contributor

@carmocca Perhaps the PR should leave the linked issue open until we have the same fix for rich?

@carmocca
Copy link
Contributor Author

carmocca commented Dec 15, 2021

@carmocca Perhaps the PR should leave the linked issue open until we have the same fix for rich?

Sure, I don't know how to unlink it, but we can re-open it once this is merged

@mergify mergify bot added the ready PRs ready to be merged label Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #11069 (e3917d5) into master (06c5903) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #11069   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16492    16498    +6     
=======================================
+ Hits        15151    15166   +15     
+ Misses       1341     1332    -9     

@carmocca carmocca merged commit 3c4d06b into master Dec 15, 2021
@carmocca carmocca deleted the bugfix/pbar-epoch-end branch December 15, 2021 17:48
awaelchli added a commit that referenced this pull request Dec 15, 2021
lexierule pushed a commit that referenced this pull request Dec 15, 2021
carmocca added a commit that referenced this pull request Feb 1, 2022
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working progress bar: tqdm ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressbar showed different value vs tensorboard and myself output
4 participants