Skip to content

Move CheckpointConnector.fault_tolerant_auto_save_path out of CheckpointConnector.hpc_resume_path #11092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2021

Conversation

jjenniferdai
Copy link
Contributor

What does this PR do?

Item 1. in #9407 (comment)
Part of #9407 cleanup, move CheckpointConnector.fault_tolerant_auto_save_path out of CheckpointConnector.hpc_resume_path.

Note that unless we change line 165 here to if self.hpc_resume_path or self.fault_tolerant_auto_save_path is not None: , this means fault-tolerant checkpoints will no longer run on_hpc_load hook (deprecated but not yet removed).
I think this is the correct behavior, though lmk if you think line 165 should be edited to preserve the same behavior as before.
https://github.com/PyTorchLightning/pytorch-lightning/blob/3c4d06bd42ff3282a017cd9fa879bbd68e8568df/pytorch_lightning/trainer/connectors/checkpoint_connector.py#L163-L166

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@jjenniferdai jjenniferdai marked this pull request as ready for review December 16, 2021 04:01
@carmocca carmocca added this to the 1.6 milestone Dec 16, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 17, 2021
@carmocca carmocca enabled auto-merge (squash) December 19, 2021 17:03
@carmocca carmocca merged commit 31f39c9 into Lightning-AI:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing fault tolerance ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants