Skip to content

Fix CLI race condition saving the config #11199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 23, 2021
Merged

Fix CLI race condition saving the config #11199

merged 11 commits into from
Dec 23, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 21, 2021

What does this PR do?

Fixes #11158

Test plan

No test as it's caused by a race condition. Testing it would require adding delays which are slow and flaky.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca added bug Something isn't working lightningcli pl.cli.LightningCLI labels Dec 21, 2021
@carmocca carmocca added this to the 1.5.x milestone Dec 21, 2021
@carmocca carmocca self-assigned this Dec 21, 2021
@carmocca carmocca enabled auto-merge (squash) December 21, 2021 16:40
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #11199 (8799905) into master (235efb3) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head 8799905 differs from pull request most recent head 015794b. Consider uploading reports for the commit 015794b to get more accurate results

@@           Coverage Diff            @@
##           master   #11199    +/-   ##
========================================
- Coverage      88%      88%    -0%     
========================================
  Files         177      177            
  Lines       16764    16557   -207     
========================================
- Hits        14782    14587   -195     
+ Misses       1982     1970    -12     

@mergify mergify bot removed the has conflicts label Dec 22, 2021
@mergify mergify bot removed the has conflicts label Dec 22, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 22, 2021

if not self.overwrite:
# check if the file exists on rank 0
file_exists = fs.isfile(config_path) if is_global_zero else False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmocca in ModelCheckpoint we have the same code except that we use fs.exists. Should we make it consistent?

This special way of checking file existence with broadcast could even become a function, as we may reuse it in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but for a follow-up.

Do you think it should be part of checkpoint io?

@carmocca carmocca merged commit f44b209 into master Dec 23, 2021
@carmocca carmocca deleted the bugfix/cli-race-cond branch December 23, 2021 16:45
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang when using Lightning CLI from config file and DDP
5 participants