-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add bagua installation in dockerfile #11283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wangraying The Script fails on MacOS |
It seems the failure on MacOS is caused by exceeding the maximum execution time. This script will not affect the workflow of |
Hi @wangraying
You're right. The failing one on macOS is a known issue tracked in #11216. As we can see from the log, the job exceeded the max time, but the actual tests passed. https://github.com/PyTorchLightning/pytorch-lightning/runs/4690064958?check_suite_focus=true#step:16:2867
|
Codecov Report
@@ Coverage Diff @@
## master #11283 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 177 177
Lines 16574 16840 +266
========================================
- Hits 15216 14848 -368
- Misses 1358 1992 +634 |
Co-authored-by: Aki Nitta <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
What does this PR do?
Fixes #10455
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃