Skip to content

Add bagua installation in dockerfile #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 24, 2022
Merged

Conversation

wangraying
Copy link
Contributor

@wangraying wangraying commented Dec 31, 2021

What does this PR do?

Fixes #10455

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11
Copy link
Contributor

@wangraying The Script fails on MacOS

@wangraying
Copy link
Contributor Author

wangraying commented Jan 4, 2022

@wangraying The Script fails on MacOS

It seems the failure on MacOS is caused by exceeding the maximum execution time. This script will not affect the workflow of ci_test-full.yml. Would you mind re-running the job? @kaushikb11

@akihironitta
Copy link
Contributor

Hi @wangraying

This script will not affect the workflow of ci_test-full.yml. Would you mind re-running the job?

You're right. The failing one on macOS is a known issue tracked in #11216. As we can see from the log, the job exceeded the max time, but the actual tests passed. https://github.com/PyTorchLightning/pytorch-lightning/runs/4690064958?check_suite_focus=true#step:16:2867

Mon, 03 Jan 2022 10:54:26 GMT === 2245 passed, 509 skipped, 11 xfailed, 3598 warnings in 630.02s (0:10:30) ===
Mon, 03 Jan 2022 11:15:08 GMT Error: The operation was canceled.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #11283 (0537fd7) into master (ff20af4) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head 0537fd7 differs from pull request most recent head ea79669. Consider uploading reports for the commit ea79669 to get more accurate results

@@           Coverage Diff            @@
##           master   #11283    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         177      177            
  Lines       16574    16840   +266     
========================================
- Hits        15216    14848   -368     
- Misses       1358     1992   +634     

@akihironitta akihironitta added the ci Continuous Integration label Jan 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 21, 2022
@stale
Copy link

stale bot commented Feb 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Feb 24, 2022
@carmocca carmocca merged commit a065561 into Lightning-AI:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bagua Training Plugin
7 participants