Skip to content

Update LightningCLI(trainer_defaults=...) doc #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2022
Merged

Update LightningCLI(trainer_defaults=...) doc #11309

merged 4 commits into from
Jan 5, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 4, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Adds comment from #7540 (comment)

Fixes #11252

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @rohitgr7 @carmocca @mauvilsa

@carmocca carmocca added docs Documentation related lightningcli pl.cli.LightningCLI labels Jan 4, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 4, 2022
@carmocca carmocca self-assigned this Jan 4, 2022
@carmocca carmocca mentioned this pull request Jan 4, 2022
Closed
@mergify mergify bot added the ready PRs ready to be merged label Jan 4, 2022
@mergify mergify bot requested a review from a team January 4, 2022 17:06
mauvilsa
mauvilsa reviewed Jan 4, 2022
View reviewed changes
tchaton
tchaton approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca enabled auto-merge (squash) January 5, 2022 19:13
@carmocca carmocca merged commit c0726ba into master Jan 5, 2022
@carmocca carmocca deleted the cli/trainer-default-docs branch January 5, 2022 19:43
@semaphore-egg semaphore-egg mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauvilsa mauvilsa mauvilsa left review comments

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees

@carmocca carmocca

Labels
docs Documentation related lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[CLI] print_config not showing correct callbacks
6 participants
@carmocca @awaelchli @mauvilsa @Borda @tchaton @rohitgr7