Skip to content

Fix min/max logging default value #11310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Fix min/max logging default value #11310

merged 3 commits into from
Jan 5, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 4, 2022

What does this PR do?

Fixes the default value used in ResultMetric for min/max reductions.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@carmocca carmocca added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Jan 4, 2022
@carmocca carmocca added this to the 1.5.x milestone Jan 4, 2022
@carmocca carmocca self-assigned this Jan 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Jan 4, 2022
@carmocca carmocca enabled auto-merge (squash) January 4, 2022 20:09
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 33c3490 into master Jan 5, 2022
@carmocca carmocca deleted the bugfix/log-min-max branch January 5, 2022 10:42
awaelchli added a commit that referenced this pull request Jan 5, 2022
awaelchli added a commit that referenced this pull request Jan 5, 2022
awaelchli added a commit that referenced this pull request Jan 5, 2022
lexierule pushed a commit that referenced this pull request Jan 5, 2022
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants