Rename _device_type to _accelerator_type
#11326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
awaelchli
approved these changes
Jan 5, 2022
|
@four4fish A deprecation is not needed, as the attribute is not public. #11002 and this PR do not block each other as best as I can tell. |
ananthsub
reviewed
Jan 5, 2022
| @@ -126,7 +126,7 @@ def setup(self, trainer: "pl.Trainer", pl_module: "pl.LightningModule", stage: O | |||
| if not trainer.logger: | |||
| raise MisconfigurationException("Cannot use GPUStatsMonitor callback with Trainer that has no logger.") | |||
|
|
|||
| if trainer._device_type != _AcceleratorType.GPU: | |||
| if trainer._accelerator_type != _AcceleratorType.GPU: | |||
There was a problem hiding this comment.
(for a separate issue/PR) i know this is a rename, but why do we need this check at all? couldn't we use the strategy's root_device instead?
There was a problem hiding this comment.
Or strategy's on_gpu property. Could be a follow up.
Borda
approved these changes
Jan 5, 2022
|
Need some refactoring for |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #9932
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7