-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Rewrite accelerator_connector #11448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 69 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
eb3a03c
Rewrite accelerator_connector
four4fish 50a82d2
update
four4fish 7307969
update
four4fish 3999d80
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c2730f9
update
four4fish c01aee5
remove print
four4fish d45eba0
fix more tests
four4fish ec17b31
change trainer.gpus
four4fish ffeea28
fix tests
four4fish 57b1642
remove gpu avalible check
four4fish d374aa9
update
four4fish 0083b69
fix horovod
four4fish 7a5c3ba
fix horovod
four4fish ca96f84
debug tpu
four4fish e55a524
fix global rank
four4fish 9996fea
fix horovod
four4fish a14879c
Update pytorch_lightning/utilities/exceptions.py
four4fish 1626eee
update horovod
four4fish e134119
address some ananth's comments
four4fish 7c1eb85
draft
four4fish 92deb7e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8aa1f68
fix ipus and cli tests
four4fish f4cca3c
fix typo
four4fish 677c6f1
fix tests
four4fish 5351621
fix pre commit
four4fish 836eb98
address comments
four4fish 18c4d9e
rename ttp to strategy
awaelchli 0bbc1c4
fix typo
awaelchli 2d54316
add typing to constructor
awaelchli f7eee05
update on comments
awaelchli 1022b25
typing, documentation improvements, adding todo's
awaelchli 932e28a
fix amp_level, amp_type mixup
awaelchli 3286de3
more typing fixes
awaelchli 774f35d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5be85d3
Update tests/models/test_gpu.py
four4fish f27d01c
Update pytorch_lightning/trainer/connectors/accelerator_connector.py
four4fish 74cbfed
Update pytorch_lightning/trainer/connectors/accelerator_connector.py
four4fish d54ccfc
Apply suggestions from code review
four4fish 653b5b8
support bagua
four4fish d000e0d
rename distributed_backend to strategy_name
four4fish 344a5e6
distributed_backend to strategy_name in tests/
four4fish 1707696
Fix tpu tests
kaushikb11 05a03d0
draft
four4fish d4c78f8
add device=0 error message and update tests
four4fish 77d2cd1
fix gpu teests
four4fish d8c5ccc
test revert accelerator auto logic
four4fish 917039f
Tiny update to choose accelerator
kaushikb11 f2d53fa
fix ipu and gpu tests
four4fish 266d3f8
add special handling for ipustrategy
four4fish 0f833f9
Address comments
four4fish 6b434e2
address comments and add kaushik's suggestions
four4fish 3560c55
Apply suggestions from code review
four4fish 55547bc
fix mypy
four4fish cc684f1
address comments and fix mypy
four4fish ce18f52
Updates to attributes
kaushikb11 88db830
Improve exceptions
kaushikb11 ee70db8
Updates to attributes
kaushikb11 c516830
Add utility methods
kaushikb11 8b07218
Handle zero/empty list values for devices flag
kaushikb11 caaf390
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cd12345
Apply suggestions from code review
four4fish a442852
address comments
four4fish 3152f81
minor comments change
four4fish 2c2e5ac
fix tests
four4fish 71dcb82
Merge branch 'master' into rewrite/acc_con
four4fish 5f32feb
minor fix
four4fish f2ab1d6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a6ff2c3
add _configure_launcher call to accl_conn
four4fish 62ce92e
Merge branch 'rewrite/acc_con' of https://github.com/four4fish/pytorc…
four4fish 869e571
Apply suggestions from code review
four4fish 9568f3b
Apply suggestions from code review
four4fish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.