Skip to content

Create comet_experiment property to replace experiment in CometLogger #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Jan 22, 2022

What does this PR do?

Creates a new comet_experiment property to replace the old experiment property.
Experiment will be deprecated in a future PR.

Part of #11234

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akashkw akashkw marked this pull request as ready for review January 22, 2022 00:42
@akashkw akashkw changed the title Create comet_experiment property to replace experiment Create comet_experiment property to replace experiment in CometLogger Jan 22, 2022
@akashkw akashkw marked this pull request as draft January 22, 2022 01:43
@akashkw akashkw closed this Jan 24, 2022
@akashkw akashkw deleted the refactor/create-comet-experiment-property branch January 24, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants