Skip to content

Remove experiment property from logger base class. #11603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 3, 2022
Merged

Remove experiment property from logger base class. #11603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
75eef59
Remove experiment from abstract class
akashkw Jan 24, 2022
aea5b8e
Add experiment property deprecation to changelog
akashkw Jan 24, 2022
e6ad908
Move changelog message from deprecated to removed
akashkw Jan 24, 2022
975fc2e
Move changelog message to the removed section
akashkw Jan 24, 2022
f8c71cb
Remove experiment from custom logger docs
akashkw Jan 27, 2022
d7c044d
Merge branch 'master' into refactor/deprecate-abstract-logger-experiment
akashkw Feb 2, 2022
977b4ee
Merge branch 'master' into refactor/deprecate-abstract-logger-experiment
carmocca Feb 2, 2022
9b7e91d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 2, 2022
cd029ea
Merge branch 'master' into refactor/deprecate-abstract-logger-experiment
akashkw Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Removed `Strategy.on_tpu` property ([#11536](https://github.com/PyTorchLightning/pytorch-lightning/pull/11536))


- Removed the abstract property `LightningLoggerBase.experiment` ([#11603](https://github.com/PyTorchLightning/pytorch-lightning/pull/11603))


- Removed `FitLoop.current_epoch` getter and setter ([#11562](https://github.com/PyTorchLightning/pytorch-lightning/pull/11562))


Expand Down
6 changes: 0 additions & 6 deletions docs/source/extensions/logging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,6 @@ Use the :func:`~pytorch_lightning.loggers.base.rank_zero_experiment` and :func:`
def name(self):
return "MyLogger"

@property
@rank_zero_experiment
def experiment(self):
# Return the experiment object associated with this logger.
pass

@property
def version(self):
# Return the experiment version, int or str.
Expand Down
5 changes: 0 additions & 5 deletions pytorch_lightning/loggers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ def update_agg_funcs(
if agg_default_func:
self._agg_default_func = agg_default_func

@property
@abstractmethod
def experiment(self) -> Any:
"""Return the experiment object associated with this logger."""

def _aggregate_metrics(
self, metrics: Dict[str, float], step: Optional[int] = None
) -> Tuple[int, Optional[Dict[str, float]]]:
Expand Down