-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Allow access to ckpt_path
within context of fit()
#11696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awaelchli
merged 6 commits into
Lightning-AI:master
from
speediedan:feature/enable_additional_finetuning_modes
Feb 5, 2022
Merged
Allow access to ckpt_path
within context of fit()
#11696
awaelchli
merged 6 commits into
Lightning-AI:master
from
speediedan:feature/enable_additional_finetuning_modes
Feb 5, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speediedan
commented
Feb 1, 2022
12 tasks
carmocca
reviewed
Feb 1, 2022
bd19fd2
to
044a67b
Compare
…t,validate,test,predict}, deprecate Trainer.{validated,tested,predicted}_ckpt_path
…instead of private and minor refactor of finetuning_callback test
044a67b
to
4008b86
Compare
carmocca
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Co-authored-by: Carlos Mocholí <[email protected]>
ananthsub
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
ananthsub
reviewed
Feb 3, 2022
awaelchli
approved these changes
Feb 5, 2022
auto-merge was automatically disabled
February 5, 2022 03:44
Head branch was pushed to by a user without write access
Awesome, thanks! @speediedan picking up some speed! |
12 tasks
ckpt_path
within context of fit()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checkpointing
Related to checkpointing
deprecation
Includes a deprecation
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes two minor changes that enable callbacks to restore checkpoints iteratively within the context of
Trainer.fit()
and prepares a deprecation path for theTrainer.{validated,tested,predicted}_ckpt_path
attributes.BaseFinetuning.__apply_mapping_to_param_groups
to protected instead of privateTrainer.{validated,tested,predicted}_ckpt_path
and replaces it with the read-only propertyTrainer.ckpt_path
set when checkpoints are loaded viaTrainer.{fit,validate,test,predict}
Fixes:
#10630
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Yes :)
Make sure you had fun coding 🙃