Skip to content

Unify checks #12069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 45 commits into from
Closed

Unify checks #12069

wants to merge 45 commits into from

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Feb 23, 2022 •
edited by github-actions bot
Loading

What does this PR do?

fixes #10821

Generalizes Type-Checks

Does your PR introduce any breaking changes? If yes, please list them.

Yes, deprecates trainer.amp_backend and MixedPrecisionPlugin.backend

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

carmocca and others added 12 commits February 18, 2022 15:26
@carmocca
Remove Trainer._strategy_type
79183b6
@carmocca
Minor change
e21d607
@carmocca
Undo change
d37ff3e
@carmocca
mypy
2c75a7b
@carmocca
Remove Trainer._device_type
e00a14b
@krshrimali @pre-commit-ci
@rohitgr7 @ananthsub @carmocca @justusschock
Support gradient accumulation using Horovod's `backward_passes_per_st…
7018049 
…ep` (#11911)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@awaelchli @carmocca @justusschock
Fix import error when running doctests for RL examples (#12010)
6e3168d 
Co-authored-by: Carlos Mocholí <[email protected]>
@carmocca @justusschock
Restore test after #11448 (#11986)
4f491a2
@four4fish @ananthsub @justusschock
Add back deterministic support in accelerator_connector (#11999)
89d7d38 

Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
@justusschock
first_start
983af0b
@justusschock
change further checks
b810bea
@justusschock
More checks
074742b
@justusschock justusschock changed the base branch from master to refactor/amp-type February 23, 2022 15:38
@justusschock justusschock changed the base branch from refactor/amp-type to refactor/device-type February 23, 2022 15:38
@justusschock justusschock changed the base branch from refactor/device-type to master February 23, 2022 15:40
justusschock and others added 15 commits February 23, 2022 16:42
@justusschock
Merge branch 'master' of github.com:PyTorchLightning/pytorch-lightnin…
5748eb6 
…g into unify_checks
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5d0457f 
for more information, see https://pre-commit.ci
@justusschock
fix missing type
e0d6e3b
@justusschock
Merge branch 'unify_checks' of github.com:PyTorchLightning/pytorch-li…
f26927e 
…ghtning into unify_checks
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d88b0b1 
for more information, see https://pre-commit.ci
@justusschock
updates
e9c4c1e
@justusschock
Merge branch 'unify_checks' of github.com:PyTorchLightning/pytorch-li…
f08702f 
…ghtning into unify_checks
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b6895d2 
for more information, see https://pre-commit.ci
@justusschock
update changelog
80add63
@justusschock
Merge branch 'unify_checks' of github.com:PyTorchLightning/pytorch-li…
83eef49 
…ghtning into unify_checks
@justusschock
mypy
d4d0ddb
@justusschock
add missing self
29c1b67
@justusschock
fix flake8
ea69ecc
@justusschock
Merge branch 'master' into unify_checks
2d0b3fa
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c3eeafa 
for more information, see https://pre-commit.ci
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda left review comments

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@ananthsub ananthsub ananthsub approved these changes

@carmocca carmocca carmocca approved these changes

@daniellepintz daniellepintz daniellepintz approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@four4fish four4fish Awaiting requested review from four4fish

Assignees

@justusschock justusschock

Labels
has conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize internal checks for precision plugin type, training type, accelerator type
10 participants
@justusschock @rohitgr7 @carmocca @Borda @ananthsub @awaelchli @daniellepintz @kaushikb11 @four4fish @krshrimali