Skip to content

Deprecate weights_save_path from the Trainer constructor #12084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 28, 2022
Merged

Deprecate weights_save_path from the Trainer constructor #12084

merged 15 commits into from
Feb 28, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Feb 24, 2022 •
edited by ananthsub
Loading

What does this PR do?

Fixes #11768

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

krshrimali
krshrimali approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ananthsub ananthsub added deprecation Includes a deprecation trainer: argument labels Feb 24, 2022
@ananthsub ananthsub added this to the 1.6 milestone Feb 24, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 24, 2022
kaushikb11
kaushikb11 reviewed Feb 24, 2022
View reviewed changes
kaushikb11
kaushikb11 reviewed Feb 24, 2022
View reviewed changes
rohitgr7
rohitgr7 approved these changes Feb 24, 2022
View reviewed changes
akihironitta
akihironitta approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Rohit's comments are addressed, LGTM!

@daniellepintz
Copy link
Contributor Author

Could someone please rerun TPU tests and enable auto merge?

@carmocca carmocca enabled auto-merge (squash) February 24, 2022 16:12
@mergify mergify bot removed the has conflicts label Feb 24, 2022
awaelchli
awaelchli reviewed Feb 24, 2022
View reviewed changes
auto-merge was automatically disabled February 25, 2022 00:09

Head branch was pushed to by a user without write access

daniellepintz
daniellepintz commented Feb 25, 2022
View reviewed changes
@mergify mergify bot removed the has conflicts label Feb 25, 2022
Borda
Borda approved these changes Feb 25, 2022
View reviewed changes
@Borda Borda self-requested a review February 25, 2022 23:51
@mergify mergify bot removed the has conflicts label Feb 26, 2022
@daniellepintz
Copy link
Contributor Author

Could someone please rerun TPU tests and enable auto merge?

@awaelchli awaelchli enabled auto-merge (squash) February 28, 2022 22:34
@awaelchli awaelchli merged commit 0fe3379 into Lightning-AI:master Feb 28, 2022
@daniellepintz daniellepintz deleted the weights_save_path branch February 28, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@krshrimali krshrimali krshrimali approved these changes

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees
No one assigned
Labels
deprecation Includes a deprecation ready PRs ready to be merged trainer: argument
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate weights_save_path from the Trainer constructor
9 participants
@daniellepintz @ananthsub @awaelchli @Borda @carmocca @krshrimali @akihironitta @rohitgr7 @kaushikb11