Skip to content

Add Habana to Azure pipes to support HPU Tests #12200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add Habana to Azure pipes to support HPU Tests #12200

wants to merge 8 commits into from

Conversation

raoakarsha
Copy link
Contributor

@raoakarsha raoakarsha commented Mar 3, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Comment on lines +119 to +121
print("All HPU tests passed")
file_name = "stdout_log.txt"
print_logs(file_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not one print?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do have two files while running the code in sub process, only when we have the error exit status we display the error_log else we only print the stdout_log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also print_logs is the method name

@akihironitta akihironitta added the ci Continuous Integration label Mar 5, 2022
@Borda Borda self-assigned this Mar 7, 2022
@Borda Borda changed the title Add hpu-tests.yml and run_hpu_tests.py to support HPU Test Add Habana to Azure pipes to support HPU Tests Mar 7, 2022
@mergify mergify bot added the has conflicts label Mar 8, 2022
@mergify mergify bot removed the has conflicts label Mar 8, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add this req. file: requirements/hpu.txt

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raoakarsha seems that this PR does hot include the integration so the testing will fail always...
so I would suggest merging this PR to the #11808

@Borda Borda closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants