Skip to content

Fix: freeze Jinja2 version #12444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Fix: freeze Jinja2 version #12444

merged 2 commits into from
Mar 24, 2022

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Mar 24, 2022

What does this PR do?

Jinja2 just released a new version and caused an internal error in the docs build. Pinning the dependency to fix it.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@mergify mergify bot added the ready PRs ready to be merged label Mar 24, 2022
@Borda
Copy link
Member

Borda commented Mar 24, 2022

Is it only for PL or all other projects?

@Borda Borda changed the title Fix docs build Jinja2 error Fix: freeze Jinja2 version Mar 24, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) March 24, 2022 15:50
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris
Copy link
Member Author

@Borda seems to be affecting everything. Same issue on Flash, I guess will hit TM too

@Borda
Copy link
Member

Borda commented Mar 24, 2022

@Borda seems to be affecting everything. Same issue on Flash, I guess will hit TM too

well thinking about really freezing all our docs requirements across projects as it is a specific task I do not expect that regular user would need building docs and if all these requirements are rather light... 🐰

@kaushikb11 kaushikb11 merged commit c099c8b into master Mar 24, 2022
@kaushikb11 kaushikb11 deleted the docs/pin_jinja2 branch March 24, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants