Skip to content

Remove pytorch_lightning.core.memory.get_gpu_memory_map #12644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Apr 6, 2022

To resolve issue #12521

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

:)
Make sure you had fun coding 🙃

@mergify mergify bot added the has conflicts label Apr 6, 2022
@rohitgr7
Copy link
Contributor

rohitgr7 commented Apr 6, 2022

I think for this we need to remove LoggerConnector.gpu_metrics, memory.get_memory_profile too since they are just sequential calls. Probably it can be done in separate PRs starting with gpu_metrics, then get_memory_profile, and finally get_gpu_memory_map.

@puhuk
Copy link
Contributor Author

puhuk commented Apr 7, 2022

@rohitgr7 Ok, then let me take get_memory_profile as well from issue #12521.
But where can I find gpu_metrics, because there is no item in #12521

@akihironitta akihironitta added the breaking change Includes a breaking change label Apr 7, 2022
@akihironitta akihironitta added this to the 1.7 milestone Apr 7, 2022
@rohitgr7
Copy link
Contributor

rohitgr7 commented Apr 7, 2022

@puhuk added at the end :)
you can do get_memory_profile and gpu_metrics together in a single PR if you want

@rohitgr7 rohitgr7 marked this pull request as draft April 7, 2022 11:32
@carmocca carmocca marked this pull request as ready for review April 12, 2022 02:17
@mergify mergify bot removed the has conflicts label Apr 12, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 12, 2022
@carmocca carmocca enabled auto-merge (squash) April 12, 2022 13:00
@carmocca carmocca disabled auto-merge April 12, 2022 14:50
@carmocca carmocca changed the title Remove pytorch_lightning.core.memory.get_gpu_memory_map [WIP] Remove pytorch_lightning.core.memory.get_gpu_memory_map Apr 12, 2022
@carmocca carmocca changed the title [WIP] Remove pytorch_lightning.core.memory.get_gpu_memory_map Remove pytorch_lightning.core.memory.get_gpu_memory_map Apr 12, 2022
@carmocca carmocca enabled auto-merge (squash) April 12, 2022 14:51
@carmocca carmocca merged commit 663216f into Lightning-AI:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants