Skip to content

Improved Deepspeed Imports #13223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Improved Deepspeed Imports #13223

merged 4 commits into from
Jun 22, 2022

Conversation

Atharva-Phatak
Copy link
Contributor

@Atharva-Phatak Atharva-Phatak commented Jun 3, 2022

What does this PR do?

As mentioned in #12786 PL needed some changes to imports. So as per the dicussion this is my First PR for Deepspeed Imports and later on I will create seprate PRs for Fairscale and all Loggers, etc.

Fixes #12786

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.7 milestone Jun 6, 2022
@carmocca carmocca added the community This PR is from the community label Jun 6, 2022
@plutasnyy
Copy link

Cool, LGTM, thanks @carmocca

@akihironitta akihironitta self-assigned this Jun 10, 2022
@akihironitta akihironitta removed their assignment Jun 10, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Jun 10, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
@awaelchli awaelchli merged commit 63a9ab4 into Lightning-AI:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the import time of pytorch_lightning
6 participants