Skip to content

fix mypy errors for distributed/dist.py #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Jul 1, 2022

What does this PR do?

fix mypy typing errors for distributed/dist.py in #13445

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca
Copy link
Contributor

carmocca commented Jul 1, 2022

Hi! I see this has no fixes yet. Converting to draft

@akihironitta akihironitta added code quality community This PR is from the community labels Jul 3, 2022
@akihironitta akihironitta modified the milestone: pl:1.7 Jul 3, 2022
@awaelchli
Copy link
Contributor

@puhuk I think we should close this PR and instead just remove the deprecated module as it's due for removal anyway. The PR #13549 would address this already.

@puhuk
Copy link
Contributor Author

puhuk commented Jul 8, 2022

@awaelchli , Thanks for the feedback and sorry for the delay :)

@puhuk puhuk closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants