Skip to content

Remove a bool type assignment in lr_finder.py #13652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Remove a bool type assignment in lr_finder.py #13652

merged 4 commits into from
Jul 15, 2022

Conversation

donlapark
Copy link
Contributor

What does this PR do?

Remove a bool type assignment of _MATPLOTLIB_AVAILABLE in pytorch_lightning/tuner/lr_finder.py. This is a follow-up from #13513 and #13445.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Remove a `bool` type assignment of `_MATPLOTLIB_AVAILABLE` in `pytorch_lightning/tuner/lr_finder.py`.
@mergify mergify bot added the ready PRs ready to be merged label Jul 14, 2022
@mergify mergify bot requested a review from a team July 14, 2022 14:18
@carmocca carmocca added this to the pl:1.7 milestone Jul 14, 2022
@carmocca carmocca enabled auto-merge (squash) July 14, 2022 15:07
@donlapark
Copy link
Contributor Author

Thanks everyone for the approvals!

There is still one problem though: the Azure Pipelines / pytorch-lightning (GPUs) (testing PyTorch - stable) check is taking an abnormally long time.

@carmocca carmocca merged commit 8e4514e into Lightning-AI:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants