Skip to content

Standalone Lite: Accelerators #14578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Sep 12, 2022
Merged

Standalone Lite: Accelerators #14578

merged 37 commits into from
Sep 12, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 7, 2022

What does this PR do?

Adds the Accelerator base class and CPU, TPU, CUDA, MPS implementations.

  • The base class has minor changes: 1) setup(Trainer) removed 2) setup_environment renamed to init_device
  • PL's Accelerator base class now subclasses Lite's Accelerator class.
  • Later on, PL can refactor their usage in strategies to completely rely on the implementations in Lite. The small blocker here currently is the usage of the trainer reference.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli changed the title Standalone Lite: Accelerator classes Standalone Lite: Accelerators Sep 7, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 7, 2022
@awaelchli awaelchli changed the base branch from master to feature/standalone-lite-utils September 7, 2022 10:06
@awaelchli awaelchli added priority: 0 High priority task refactor fabric lightning.fabric.Fabric labels Sep 7, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 7, 2022
@awaelchli awaelchli self-assigned this Sep 7, 2022
Base automatically changed from feature/standalone-lite-utils to master September 7, 2022 15:25
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 7, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 7, 2022
@awaelchli awaelchli marked this pull request as ready for review September 7, 2022 23:08
@awaelchli awaelchli requested a review from tchaton as a code owner September 7, 2022 23:08
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Previous unresolved comments about moving implementations can be TODO(lite)s

@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli enabled auto-merge (squash) September 12, 2022 15:11
@carmocca carmocca disabled auto-merge September 12, 2022 15:29
@carmocca carmocca enabled auto-merge (squash) September 12, 2022 15:31
@carmocca carmocca merged commit d013bcc into master Sep 12, 2022
@carmocca carmocca deleted the lite/accelerators branch September 12, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants