Skip to content

CI: Use self-hosted Azure GPU runners #14632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Oct 5, 2022
Merged

CI: Use self-hosted Azure GPU runners #14632

merged 68 commits into from
Oct 5, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 9, 2022 •
edited by github-actions bot
Loading

What does this PR do?

image

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added the ci Continuous Integration label Sep 12, 2022
@Borda Borda self-assigned this Sep 12, 2022
@Borda Borda added this to the pl:future milestone Sep 12, 2022
@Borda Borda marked this pull request as ready for review September 15, 2022 23:58
@Borda Borda requested review from awaelchli, kaushikb11 and a team September 16, 2022 00:06
@Borda Borda modified the milestones: pl:future, all:next Sep 16, 2022
@Borda Borda changed the title Ci/azure runner CI: azure GPU runners Sep 16, 2022
@Borda Borda enabled auto-merge (squash) September 16, 2022 00:08
@Borda Borda disabled auto-merge September 16, 2022 06:39
carmocca
carmocca reviewed Sep 16, 2022
View reviewed changes
@carmocca carmocca force-pushed the ci/azure-runner branch 2 times, most recently from d76beca to dc2e16c Compare September 27, 2022 17:12
@carmocca carmocca mentioned this pull request Sep 27, 2022
Merged
@carmocca carmocca requested a review from otaj as a code owner September 29, 2022 15:57
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 29, 2022
@Borda
Copy link
Member Author

Borda commented Oct 5, 2022

argument --runtime=nvidia was deprecated in favor of --gpus=all
see: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4585

@Borda Borda requested a review from carmocca October 5, 2022 09:37
carmocca
carmocca approved these changes Oct 5, 2022
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Oct 5, 2022
carmocca
carmocca reviewed Oct 5, 2022
View reviewed changes
@Borda Borda requested a review from carmocca October 5, 2022 09:46
@Borda Borda enabled auto-merge (squash) October 5, 2022 09:47
@Borda Borda merged commit 5f10695 into master Oct 5, 2022
@Borda Borda deleted the ci/azure-runner branch October 5, 2022 10:43
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@Borda @pre-commit-ci
@carmocca @akihironitta @otaj @nicolai86
CI: Use self-hosted Azure GPU runners (#14632)
7de999a 
* move config
* Apply suggestions from code review

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: otaj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaj otaj otaj approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees

@Borda Borda

Labels
ci Continuous Integration ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
all:next
Development

Successfully merging this pull request may close these issues.
7 participants
@Borda @awaelchli @wangraying @otaj @carmocca @justusschock @akihironitta