Skip to content

More tests for TPU accelerator in Lite #14960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 8, 2022
Merged

More tests for TPU accelerator in Lite #14960

merged 18 commits into from
Oct 8, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 30, 2022

What does this PR do?

This PR adopts remaining tests from PL for Lite. Similar to #14901 etc.
This is based on #14926 and should be debugged/merged after CI is enabled again.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @kaushikb11 @rohitgr7 @carmocca @justusschock @awaelchli @Borda

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 30, 2022
@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit fabric lightning.fabric.Fabric tests and removed pl Generic label for PyTorch Lightning package labels Sep 30, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 30, 2022
@awaelchli awaelchli self-assigned this Sep 30, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 30, 2022
@awaelchli awaelchli marked this pull request as ready for review October 6, 2022 07:43
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check out the tests in tests/tests_pytorch/models/test_tpu.py. Here on in a separate PR

@carmocca carmocca removed the pl Generic label for PyTorch Lightning package label Oct 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 6, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #14960 (7f5010f) into master (4bad54f) will increase coverage by 2%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #14960     +/-   ##
=========================================
+ Coverage      83%      85%     +2%     
=========================================
  Files         400      280    -120     
  Lines       29498    21519   -7979     
=========================================
- Hits        24413    18223   -6190     
+ Misses       5085     3296   -1789     

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 7, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 8, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 8, 2022 11:19
@awaelchli awaelchli disabled auto-merge October 8, 2022 11:20
@awaelchli awaelchli enabled auto-merge (squash) October 8, 2022 11:22
@awaelchli awaelchli merged commit c76a95e into master Oct 8, 2022
@awaelchli awaelchli deleted the lite/tpu-tests branch October 8, 2022 15:42
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants