-
Notifications
You must be signed in to change notification settings - Fork 3.5k
More tests for TPU accelerator in Lite #14960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4d6c0a
to
31789a1
Compare
for more information, see https://pre-commit.ci
awaelchli
commented
Oct 6, 2022
awaelchli
commented
Oct 6, 2022
carmocca
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also check out the tests in tests/tests_pytorch/models/test_tpu.py
. Here on in a separate PR
justusschock
approved these changes
Oct 6, 2022
a3b7743
to
1c8c1c9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14960 +/- ##
=========================================
+ Coverage 83% 85% +2%
=========================================
Files 400 280 -120
Lines 29498 21519 -7979
=========================================
- Hits 24413 18223 -6190
+ Misses 5085 3296 -1789 |
nicolai86
pushed a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: tpu
Tensor Processing Unit
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adopts remaining tests from PL for Lite. Similar to #14901 etc.
This is based on #14926 and should be debugged/merged after CI is enabled again.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @kaushikb11 @rohitgr7 @carmocca @justusschock @awaelchli @Borda