-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Error messages for removed Trainer mixin methods #15065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 1d3e971.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of graveyard, but wouldn't it be neater to have a magic decorator, that would take as params what is deprecated, when it was deprecated and removed and what should be used instead? I feel like we're duplicating quite a lot of text, that could be stored within this one magic function. cc @carmocca
@otaj You would need to be more specific with your proposal. But in general, we don't care much about what's inside the graveyard (it's all dead code!) In my PR, I did some hacking to create classes dynamically and write less code: https://github.com/Lightning-AI/lightning/pull/15061/files#diff-6ccf6181b48656c99d6106f8a2c2f98904cdc7f06155bdffd9b02ec5afa48c45R51 but I don't think we really need to care about writing the least possible lines of code. So, if you have a specific suggestion, we can totally add it as long as it's self-contained inside the graveyard |
@carmocca, perfectly fair, this was just an idea in my head. The argument, that it's all dead code, is perfectly valid., let's disregard my comment 😄 ⚡ |
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
Follow up to #14888, #14887 in accordance to #15049.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @ananthsub @ninginthecloud @jjenniferdai @rohitgr7 @akihironitta