Skip to content

Error messages for removed Logger APIs #15067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 11, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 10, 2022

What does this PR do?

Follow up to #14840, #14283 in accordance to #15049.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @awaelchli @edward-io @Borda @ananthsub @rohitgr7 @Blaizzy @justusschock

@awaelchli awaelchli added logger Related to the Loggers breaking change Includes a breaking change labels Oct 10, 2022
@awaelchli awaelchli self-assigned this Oct 10, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 10, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Oct 10, 2022
@awaelchli awaelchli marked this pull request as ready for review October 11, 2022 09:23
@mergify mergify bot removed the has conflicts label Oct 11, 2022
@mergify mergify bot removed the has conflicts label Oct 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 11, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 11, 2022 19:09
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 11, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 11, 2022
@awaelchli awaelchli merged commit 16419f3 into master Oct 11, 2022
@awaelchli awaelchli deleted the feature/remove/logger-api branch October 11, 2022 21:16
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change logger Related to the Loggers pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants