Skip to content

Use per-package imports in docs #15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2022
Merged

Use per-package imports in docs #15124

merged 2 commits into from
Oct 13, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 13, 2022 •
edited by github-actions bot
Loading

What does this PR do?

addressing #15095 (comment) as separate work

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 13, 2022
@Borda Borda added bug Something isn't working and removed app (removed) Generic label for Lightning App package labels Oct 13, 2022
@Borda Borda enabled auto-merge (squash) October 13, 2022 12:44
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 13, 2022
@Borda Borda requested review from carmocca, otaj and a team October 13, 2022 12:53
@Borda Borda added this to the v1.8 milestone Oct 13, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 13, 2022
@carmocca carmocca changed the title fix import to be true stand-alone Use per-package imports in docs Oct 13, 2022
@carmocca carmocca disabled auto-merge October 13, 2022 13:47
@carmocca carmocca enabled auto-merge (squash) October 13, 2022 13:48
@Borda
Copy link
Member Author

Borda commented Oct 13, 2022

confirmed with @krshrimali that the App pytest example failure is unrelated
cc: @tchaton

@lexierule lexierule disabled auto-merge October 13, 2022 14:15
@lexierule lexierule merged commit ee07de8 into master Oct 13, 2022
@lexierule lexierule deleted the pkg/app-standalone branch October 13, 2022 14:15
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@Borda @pre-commit-ci @nicolai86
Use per-package imports in docs (#15124)
3aec3af 
* fix import to be true stand-alone

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
@Borda @pre-commit-ci @nicolai86
Use per-package imports in docs (#15124)
a300ce1 
* fix import to be true stand-alone

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@rohitgr7 rohitgr7 mentioned this pull request Oct 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@otaj otaj otaj approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@manskx manskx Awaiting requested review from manskx

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@Borda @awaelchli @otaj @justusschock @lexierule