Skip to content

[App] Remove an example #15586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[App] Remove an example #15586

wants to merge 11 commits into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 8, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 8, 2022
@tchaton tchaton marked this pull request as ready for review November 8, 2022 14:37
@mergify mergify bot added the ready PRs ready to be merged label Nov 8, 2022
@carmocca carmocca added this to the v1.8.x milestone Nov 8, 2022
@Borda
Copy link
Member

Borda commented Nov 8, 2022

@tchaton what is the motivation?

@tchaton
Copy link
Contributor Author

tchaton commented Nov 9, 2022

@Borda @williamFalcon asked to hide Lite examples for now.

@tchaton tchaton enabled auto-merge (squash) November 9, 2022 14:07
@tchaton tchaton changed the title Remove an example [App] Remove an example Nov 9, 2022
@Borda
Copy link
Member

Borda commented Nov 9, 2022

What does it mean for now, like today? or for the next release?

@awaelchli awaelchli mentioned this pull request Nov 10, 2022
12 tasks
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Nov 10, 2022
@tchaton
Copy link
Contributor Author

tchaton commented Nov 10, 2022

What does it mean for now, like today? or for the next release?

This came from @lantiga.

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Nov 10, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package has conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants