testing new speed #1587
Merged
testing new speed #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this a work in progress? only change i see here is adding some prints |
|
This pull request is now in conflict... :( |
|
@Borda we need to merge+close this |
sure, I ll take it as priority now |
Codecov Report
@@ Coverage Diff @@
## master #1587 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 75 75
Lines 4705 4705
======================================
- Hits 4064 4062 -2
- Misses 641 643 +2 |
|
This pull request is now in conflict... :( |
Borda
approved these changes
Jun 3, 2020
|
@williamFalcon it is ready now, the docs will be updated in #2072 |
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* fixed new amp bugs * fixed new amp bugs * fixed new amp bugs * try exit * larger dataset * full mnist * full mnist * trainer * assert * .05 * .10, #4 * #5 * #5 * #5 * refactor * abs diff * speed * speed * speed * speed Co-authored-by: J. Borovec <[email protected]> Co-authored-by: Jirka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃